vdanyliv / ngx-tiny-slider

Angular wrapper for tiny-slider
https://npmjs.com/package/ngx-tiny-slider
MIT License
15 stars 18 forks source link

New version of tiny-slider on npm. ngx-tiny-slider dont work any more correctly #30

Open SvenBudak opened 4 years ago

SvenBudak commented 4 years ago

Hi! :)

There is a new version from tiny-slider on npm. i get some new errors now:

ERROR in node_modules/tiny-slider/src/tiny-slider.d.ts:243:5 - error TS2300: Duplicate identifier 'preventScrollOnTouch'.

243     preventScrollOnTouch?: "auto" | "force" | false;
        ~~~~~~~~~~~~~~~~~~~~
node_modules/tiny-slider/src/tiny-slider.d.ts:260:5 - error TS2300: Duplicate identifier 'preventScrollOnTouch'.

260     preventScrollOnTouch?: "auto" | "force" | false;

maybe there are more problems, but this is what i get. you can see the issue post about the update here: https://github.com/ganlanyuan/tiny-slider/issues/588

best regards

Duarte10 commented 4 years ago

Having the same issue, if anyone found a solution please share it :)

Duarte10 commented 4 years ago

Having the same issue, if anyone found a solution please share it :)

Fixed it in my angular project by going to the package.json file and specifying the tiny-slider version prior to the latest release.

SvenBudak commented 4 years ago

@Duarte10 this is not a fix... we are all happy that tiny-slider gets after 2 years a update to npm lib.

Duarte10 commented 4 years ago

@Duarte10 this is not a fix... we are all happy that tiny-slider gets after 2 years a update to npm lib.

That's why I said I fixed it in my angular project, if someone else also has an app in production that uses ngx-tiny-slider and doesn't have the time to wait for a new ngx-tiny-slider release that accommodates the changes in the recent tiny-slider release to npm, they can apply this "fix" to their project.

vdanyliv commented 4 years ago

the latest release of tiny-slider didn't fix the problem

SvenBudak commented 4 years ago

Thats sad.. but you anyway plan to make a update for ngx-tiny-slider?

vdanyliv commented 4 years ago

Of-course @SvenBudak

vdanyliv commented 4 years ago

new PR raised https://github.com/ganlanyuan/tiny-slider/pull/598

ttong9 commented 4 years ago

Hi, is there any update on this bugfix?

That's why I said I fixed it in my angular project, if someone else also has an app in production that uses ngx-tiny-slider and doesn't have the time to wait for a new ngx-tiny-slider release that accommodates the changes in the recent tiny-slider release to npm, they can apply this "fix" to their project.

In the meantime, @Duarte10 can you please confirm which version worked for you?

Duarte10 commented 4 years ago

Hi, is there any update on this bugfix?

That's why I said I fixed it in my angular project, if someone else also has an app in production that uses ngx-tiny-slider and doesn't have the time to wait for a new ngx-tiny-slider release that accommodates the changes in the recent tiny-slider release to npm, they can apply this "fix" to their project.

In the meantime, @Duarte10 can you please confirm which version worked for you?

2.9.2

vdanyliv commented 4 years ago

Hi, is there any update on this bugfix?

That's why I said I fixed it in my angular project, if someone else also has an app in production that uses ngx-tiny-slider and doesn't have the time to wait for a new ngx-tiny-slider release that accommodates the changes in the recent tiny-slider release to npm, they can apply this "fix" to their project.

In the meantime, @Duarte10 can you please confirm which version worked for you?

no updates

ttong9 commented 4 years ago

thank you

vdanyliv commented 4 years ago

@SvenBudak @ttong9 @Duarte10 what if I create a fork of the original tiny-slider and we start fixing bugs more often? What do you think guys?

SvenBudak commented 4 years ago

I don't think that I am a big help. My logic skills are limited. I am more specialized in UX and UI. But I would still be happy about an updated version :)

Paul75 commented 2 years ago

same problem and not fixed ....