search

vdaron / MusicXml.Net

Quick C# parser for MusicXML
Other
58 stars 27 forks source link

Completely refactor the way parsing is done #2

Closed steven-solomon closed 10 years ago

steven-solomon commented 10 years ago

Everything now has test coverage. I also added the ability to parse forward and backward tags and I had to remove the dependency on MindTouch so I could implement IsRest and IsChordTone.

steven-solomon commented 10 years ago

I need to close this as I just found a bug in parsing note's pitch

vdaron commented 10 years ago

Hi Steven,

You're doing an awsome job here, I've just add you as a collaborator on the project, so that you can work directly here.

Do not hesitate to drop me an email!

Vincent.

steven-solomon commented 10 years ago

Hey Vincent,

Thanks! I'll merge the changes in Monday.

Have a good one. Steven Solomon

Sent from my Apple Lisa.

On May 8, 2014, at 6:03 PM, Vincent DARON notifications@github.com wrote:

Hi Steven,

You're doing an awsome job here, I've just add you as a collaborator on the project, so that you can work directly here.

Do not hesitate to drop me an email!

Vincent.

— Reply to this email directly or view it on GitHub.

steven-solomon commented 10 years ago

Hey Vincent,

I just cut a release of MusicXml.Net and I noticed that the project isn’t in NuGet yet. If you don’t already have an account for this I’d like to create one and upload the project there. I will share the credentials with you of course.

Also I’d like to contact the people at MusicXml.com and get your project listed there.

Thanks Steve

On May 8, 2014, at 6:45 PM, Steve solomon.steven.m@gmail.com wrote:

Hey Vincent,

Thanks! I'll merge the changes in Monday.

Have a good one. Steven Solomon

Sent from my Apple Lisa.

On May 8, 2014, at 6:03 PM, Vincent DARON notifications@github.com wrote:

Hi Steven,

You're doing an awsome job here, I've just add you as a collaborator on the project, so that you can work directly here.

Do not hesitate to drop me an email!

Vincent.

— Reply to this email directly or view it on GitHub.

vdaron commented 10 years ago

Hi Steven,

I planned to make a official release with nuget package based on your modifications :-)

I already have a nuget account, I'll create the package before Monday.

I just find you on twitter, drop me a private message, I'll give you my email address, it's easier to discuss.

Tks