mod: retro flip clock

[mgonzales71]

what do you think? :jack_o_lantern:

in this mod I ignore colons, color and transparency for time (hh/mm) and am/pm will show if clock is 12 hour format. also added seconds that change per second. actually in this mod the time is taken from SystemTime() via skin InfoLabels now.

pic of both 24 and 12 format (as set by clock format in kodi settings - appearance - international)

http://pastebin.com/ygEmUC2j

[vdb86]

Looks pretty good! I was trying to avoid images in the screensaver since I felt like it was better for the screensaver to follow the "look" of the skin (since it has to use skins fonts). I'll think about adding this, although I'm not to keen on doing it, even though it looks good :D

[mgonzales71]

well if you do change your mind let me know and I can send you the images. the total size of all the png formatted images is about 2.6 mb

my plan is to make this a skin "mod" option in Titan so users won't get confused when adjusting the screen savers settings doesn't work as expected.

wanted to run this past you first because this is your baby and if you wanted to include this "feature" I would hold off so not to duplicate the efforts.

[vdb86]

At this point I'm still not sure if I want to implement it or not, looks good but it's something I was trying to avoid. I'd say go ahead, this is a great skin mod and users deserve to have something "additional" with your skin :) Thanks for checking with me! And thank you for all your effort!

[mgonzales71]

no problem - feel free to msg me if you want any images, code, questions, etc anytime.

SO here is a puzzle for you..

on Windows 10 x64 running Kodi 15.2 - Titan Skin Beta and your latest code...

I have tried this with a custom xml or the default xml and both ways will cause either kodi to crash (ick!) or your script to die/crash.

here is the scenario that I can do to reproduce the problem over and over on my system..

set the display of random background images, enable info, weather, weather icons, date, time, etc basically all info. set screen saver slideshow images to rotate every 15s and your script to "move" every 10s

now start a movie playing.... I played an mp4 off my NAS

go to appearance screensaver and start your screensaver (preview) while the movie is playing in the background.

the script should die or kodi may crash. seems to happen when your script is about yo update/mode the displayed info to a new location on the screen.

see if you can reproduce this on your system.

here are some logged errors to possibly help

http://pastebin.com/87teKcmk

[mgonzales71]

now - I don't even know if the screensaver will activate when a video etc is in active playback so maybe this issue is not really an issue?

[vdb86]

To be honest I have no clue, it seems that if something does go wrong it's connected to python. One person contacted me on Kodi forum and said that he's having issues with my screensaver on his system running latest Isengard 15.2 on Debian Linux compiled from git repo. I can't reproduce his problems, but from what he described it seems that the python is the culprit. After that Martijn asked me why I don't properly Initialize self.conditions. I have no clue what that even means, but he might see some issue with the way I wrote the code, unfortunately he didn't comment anything further, so I have no clue what the problem is. Checked out the python documentation and can't figure out what he was asking me.

The short story: If the screensaver isn't working, it's most probably something to do with python, since several things are imported using python libraries.

[mgonzales71]

try a test for me on your system.

start a video playing then start a preview of your screensaver with settings similar to: http://pastebin.com/ikjrrUfX

and see if you see errors in the log or crash of the app if you have Titan Beta installed that is what I am running.

I am starting to think that screensaver wont start if a video is in active playback anyway so could not even be an issue.

you could have your script check to see if video is in active playback and then

1) just exit as a way to handle the unlikely scenario that someone invokes the screensaver while video is playing back. 2) send a pause to playercontrol

the script does not crash if the video is paused.

I tried adding this to the custom xml file.

PlayerControl(Play)

that will pause playback... but I still see the script die

idk - maybe like I said it;s not an issue since only time this will happen is if use forces screensaver to activate during video playback.

[mgonzales71]

git is not displaying my xml code above properly.. here is the onload command I used to test pausing if playback is active...

[vdb86]

To be honest I never tried to start the screensaver when the video is playing. Except for the case that someone does it by pressing preview there is no other way (that I'm aware off). With music everything works fine while it's playing!

[mgonzales71]

here is the skin customization for Titan Beta.

new setting in skin

If custom skin setting is NOT enabled - screensaver will honor all of its settings:

Custom Look - follows in use theme colors, skin weather icon setting

screensaver with skin customization in action (music playing to demonstrate now playing info line)

https://onedrive.live.com/redir.aspx?cid=599da6bd82779e65&resid=599DA6BD82779E65!5957&parId=599DA6BD82779E65!4605&authkey=!ANtncXuFcVnqRw4&ithint=video%2cmp4

screensaver in typical state - nothing playing

https://onedrive.live.com/redir.aspx?cid=599da6bd82779e65&resid=599DA6BD82779E65!5958&parId=599DA6BD82779E65!4605&authkey=!ACu99WbcTHnY-2Q&ithint=video%2cmp4

[vdb86]

Looks good!

[vdb86]

Hey Mario, I've changed the xbmc.sleep part as they requested it on the mailing list. While I was at it I added the bounce type of movement on the screen. When you get a chance take a look and let me know if it works for you and what you think. Thanks!

[mgonzales71]

Just saw this - I will test it here shortly.

Have you tested your screensaver on Jarvis? I tried it on the Alpha 4 build and it doesn't work.

I tried it on both Windows and Linux.

I also saw the same problem with a couple other screensavers as well ( any that use a default.py) so I'm wondering if something has changed?

I'll let you know how my testing goes for your latest build... on Isengard :)

Sent from my iPhone

On Nov 1, 2015, at 9:29 AM, vdb86 notifications@github.com wrote:

Hey Mario, I've changed the xbmc.sleep part as they requested it on the mailing list. While I was at it I added the bounce type of movement on the screen. When you get a chance take a look and let me know if it works for you and what you think. Thanks!

— Reply to this email directly or view it on GitHub.

[mgonzales71]

works good for me.. only suggestion(s) only because I know it will be asked eventually on the forum... maybe provide a slow/med/fast bounce speed

also - consider displaying background images with scale to avoid black bars on tops and/or sides or images that are off aspect of the users monitor.

even if you don't change anything - awesome as usual.

let me know how your testing on Jarvis A4 goes.

Thanks!

Mario

[mgonzales71]

off course git removes part of my post/reply... I meant consider adding: << aspectratio>> scale <<//aspectratio>> (had to double the chars to get it to display - stupid markdown) hehe

[vdb86]

I haven't even come close to testing Jarvis, I'll deal with it later :D I'll take a look at the speed settings and aspectratio!

[vdb86]

Added the option for bounce speed (slow, normal, fast) and changed the aspectratio to scale. I'll try it out for a day or two and then get it official.

[vdb86]

I've found two bugs and fixed them! Quick question, this screensaver completely doesn't work with Jarvis?

[mgonzales71]

No - throws an error with the ADDON definition. I think I may know the problem there - will test when I get home. Think Jarvis changed up a few Python libraries / includes.

Sent from my iPhone

On Nov 3, 2015, at 7:23 AM, vdb86 notifications@github.com wrote:

I've found two bugs and fixed them! Quick question, this screensaver completely doesn't work with Jarvis?

— Reply to this email directly or view it on GitHub.

[mgonzales71]

Awesome! - I will test later this evening. Sorry for the delay in my reply.. Was sick the last couple days - feeling lots better. I'm just glad it wasn't the flu - two of my friends already have had it. Not fun.

Sent from my iPhone

On Nov 2, 2015, at 6:11 AM, vdb86 notifications@github.com wrote:

Added the option for bounce speed (slow, normal, fast) and changed the aspectratio to scale. I'll try it out for a day or two and then get it official.

— Reply to this email directly or view it on GitHub.

[vdb86]

I'm glad you're feeling better! Take your time, there's no rush :)

[mgonzales71]

tested latest build out - works great! I would say it should be good for pushing to the main repo :)

Marcel is starting to move titan skin dev to jarvis so I am going to set up a test/dev environment to work with Jarvis myself - once I have that set up again I will re-test your screen saver and see if it works and if the change I think may be needed works or not.

[vdb86]

Sounds good, thanks Mario!

[mgonzales71]

While researching the issue with Jarvis I found out it is a bug - http://trac.kodi.tv/ticket/16361 looks like someone beat me to it 35 hours ago :)

the ticket says the issue was also in 15.2 but I don't have the problem in 15.2 just 16-a4

will re-test once the ticket/issue is closed (and marked fixed)

[vdb86]

Yeah I'm not seeing this on 15.2 either, works as it should. Awesome, thanks Mario!

[mgonzales71]

well they fixed that bug fast - looks like it's marked for jarvis beta 1

could end up in one of the nightlies before that

https://github.com/xbmc/xbmc/pull/8349

[vdb86]

Sounds good, hopefully that fixes the issue!

[mgonzales71]

they indeed have fixed it - tested it in one of the nightlies of Jarvis recently.

[vdb86]

Awesome!

[vdb86]

Mario my friend, happy New Year to you and your family!

I was playing around yesterday with Titan skin and I must admit to you guys that your skin is pretty sweet. I thought that Aeon MQ had the most options of all skins but you guys are on pair with it as far as I see. I would even go as far as saying that you have some options that Aeon MQ is seriously lacking. I can't speak for the performance though, I haven't spent enough time with the skin yet.

All in all thanks for being a part of the team that made this awesome skin!

I also tried it on my Nexus 7, but I'm running into problems with using Kodi on an android tablet. All skins seem to exhibit the same behavior: After some time, touching a menu, or an option doesn't activate it, sometimes the option gets highlighted but nothing happens. This especially happens to a "second" menu or additional options. If a movie is playing I can get the OSD menu to show but I might not be able to select anything on it (Stop the movie etc.). Of course I have tried all of this with re-Touched too, same results. I even tried it with Jarvis RC1, same thing is happening. The rest of my applications work just fine. Not sure what the issue is really.

[mgonzales71]

I have seen this as well and is one of the main reasons I use Windows typically and when I use Android (like FireTV) I use the hardware remote or my phone to control Kodi.

I have resorted to even using my phone to control Kodi on my Android tablet at times.

95% of my use of Kodi is on Windows or FireTV.

I have never been motivated enough to investigate this issue on the Forums but I don't think it is related to a specific skin as you have noticed.

Relaunching the Android App resolves the issue for a while but it always seems to return.

Have you turned on debugging in Kodi and enabled touch feedback on android?

If my android tablet was working at the moment (bricked it last week and haven't had time to unbrick it yet) I would do some more testing but maybe you can try to collect some debug logs on Kodi and Android and post a bug report and see if others have seen the same issue and the Devs can address it.

once I get my tablet back up I an also do some testing myself now that I have some free time to

Happy New Year to you as well btw! :)

Mario

[vdb86]

I haven't done any debug logging but I'll give it a shot! I've tried Kodi on Galaxy Tab 3 running Android 4.2.2 and everything works great, no issues like with the Nexus 7. At this point I'm wondering if the issue lies in newer Android operating system since the Nexus is on Android 5.1.1 or the Nexus 7 hardware itself. I'll do some more testing and will let you know if I dig something up.

[vdb86]

I think I have found the culprit! If I'm using my tablets software keys everything works just fine but if I use a touch gesture - Back - Two finger swipe to the left then the trouble starts. The next touch is recognized and everything afterwards is problematic. I have the debug log and looked it over but unfortunately nothing shows up. I have tested this several times, this is definitely an issue! Now to figure out how to make a bug report when the debug log doesn't show anything.

[vdb86]

This is the debug log, you might be able to see something that I'm missing: http://xbmclogs.com/pfiaqh9pj

[vdb86]

Downgraded to 4.4.4, same thing. Found a workaround, just use some gesture app and avoid using 2 finger back gesture :)

[vdb86]

Hey Mario, I've got a couple of questions. I'm playing around with Titan skin, trying to set it up as I like it. Is there any way I can set up my movie library to be all icons and use the whole screen? I've set up the Panel Wall view and disabled header and footer, that freed u a lot of space but the number of icons is the same. I think a whole row of icons can be put in the current free space! It would be cool to have another row of icons (even with either header or footer enabled) or just have an option to choose a bit bigger icons with smaller spacing between them (maybe an option to disable the icon poping out). For example 8x3 with header and footer disabled. 9x3 For either header or a footer And 10x3 for both. Also is there a way to enlarge fonts in the main menu? The whole panel is pretty big and the text is less than half it's width.

Sorry for the long message, is there any other place we can chat? Kodi forum private messages?

[vdb86]

Mario! I'd like to implement color picker from skin helper :) I've played around with the whole thing but addons are stuck with with specific settings, any idea how I could implement this? I'd also like to make music visualization available as a background, failed at that too... If you have any tricks up your sleave I'm interested :)

[mgonzales71]

Hmmm - well I will have to think about this one - skins have more control over settings then screensavers do - in a skin you can call scripts, etc - which is what you are doing with the colorpicker via the skin helper script addon. were you able to actually call the script?

[mgonzales71]

oh - i just thought of not so pretty way to do what you want..... basically in your settings and readme - put a comment for the use to press (i don't know) C to Configure advanced settings and then call a .xml in skin syntax which you can have your script display but i am pretty sure unless you write the code to save the settings elsewhere they will be saved in the current skin's settings.xml under userdata.

i actually started working on a screensaver that basically let the skin authors create screensavers custom to their skins - need to get around to finishing it. this approach opens up a lot more options and control but the skin authors need to embrace it or you would need an xml specific to each skin you wanted to support.

https://github.com/mgonzales71/screensaver.skinnable

[mgonzales71]

feel free to use the code etc as you like btw. I was going to approach this author to collaborate but again never got around to it - but i could see a combo of all 3 screensavers + more being a cool thing :smile:

https://github.com/Ignoble61/screensaver.info.screen

[vdb86]

Yeah it would probably just save everything under current skin's settings.

I have the same bottom part of the code, if you remeber you suggested this quite some time ago so I implemented it :) Technically this makes screensaver.digitalclock customizable by skinners, although I haven't really tested it out completely. Screensavers have a ton of limitation in Kodi so it's rather hard to do some things.

I'll check out the second one too!

Is there any other place we can discuss stuff, this is rather public :D Are you on Kodi forum by any chance?