vdellamea / jamulus-server-remote

A web-based remote for Jamulus server
17 stars 8 forks source link

Version in install-remote.sh not correct #3

Open henkdegroot opened 3 years ago

henkdegroot commented 3 years ago

Thanks for creating this great piece of work. I noticed the version in the install-remote.sh is not correct. At first I thought I downloaded an older version because of this.

Also, the script indeed fails towards when it creates the folders in /home/jamulus and set the access right. As this home folder does not exist...and you mentioned that is does not if you followed to "official" jamulus installation instructions. It would be nice to have some more information on this or setup/create some default folder at another location.

vdellamea commented 3 years ago

The home folder should be created by the mkhomedir_helper command. For other places, I think the issue may come from privileges of the service file (in this service file there is a ProtectHome=false directive to enable writing in the home), but I am not an expert on this. I updated the version number in the script, thanks.

henkdegroot commented 3 years ago

Thanks for the information. On my system I already had jamulus-headless installed and this normally has the service running. The usermod and mkhomedir do not seem to like being executed because of the running service. When the service is not running, the commands execute fine (at least on my system).

With this resolved, I got to the next issue...which is writting to the /home/jamulus/recording folder. Which indeed is caused by the "ProtectHome" option. When the jamulus-headless package is install, this will have the value set to "true" and matches the jamulus site (it says jamulus can't record into the home folder).

Perhaps you can "hint" both in the readme file?