Update MtApi.mq4 - Githubissues

vdemydiuk / mtapi

MetaTrader API (terminal bridge)

http://mtapi4.net/

MIT License

511 stars 276 forks source link

Update MtApi.mq4 #238

Open eabase opened 3 years ago

eabase commented 3 years ago

Fixed formatting, encoding and trading bug

Fixed preventive use of trading password (bug #223)
Converted file from weird UTF-16LE to UTF-8
Removed blank trailing spaces
Removed tabs and converted mixed 3-tab indentation to 4-spaces
Simplified and reduced the Case statements
Changed old-school "fun() \n {" to "fun() {" formatting, saving 1500 lines.
Bumped version to 1.15

vdemydiuk commented 3 years ago

@eabase please make PR into dev branch. I will merge it into master from dev.

eabase commented 3 years ago

@vdemydiuk If you want to compare this to your version, you need to change the character encoding of your version. It seem that GitHub thinks its binary... use:

iconv.exe -f UTF-16 -t "ASCII" MtApi.mq4 >MtApi.cpp

Or to UTF-8. Then:
mv MtApi.cpp MtApi.mq4.

BryanStackpole commented 3 years ago

Hi, so when I try compile this file I get 124 errors? is there an error free version? May need to make custom commands.

eabase commented 3 years ago

@BryanStackpole

Hi, so when I try compile this file I get 124 errors? is there an error free version? May need to make custom commands.

Nobody can help you if you don't file a proper bug report of what you did, and what the output is. ...and this are comments for a pull request, not the issue section.

BryanStackpole commented 3 years ago

@BryanStackpole

Hi, so when I try compile this file I get 124 errors? is there an error free version? May need to make custom commands.

Nobody can help you if you don't file a proper bug report of what you did, and what the output is. ...and this are comments for a pull request, not the issue section.

Yeah sry about that. I think the answer is in the readme.