search

vdevauxchupin / ITS_LIVE_TOOL

Repository gathering useful notebooks and code to work with ITS_LIVE Data
Apache License 2.0
6 stars 2 forks source link

cleaning environment and adding binder link #45

Closed betolink closed 9 months ago

betolink commented 9 months ago

This PR is to use a simpler compatible conda environment, it works for OSX and Linux, the blocker for Windows was the pytorch library, it can be installed but didn't want to mix more channels.

I tested the 2 roadmap notebooks and the imports worked fine, I wonder if we can test the other notebooks to make sure we are not missing anything. Just in case the old environment is still here as backup.

e-marshall commented 9 months ago

Thanks so much @betolink ! This looks awesome. We also might not even need pytorch now that we've pulled the gaussian process model. Unless it is used in the GPU implementation of the inversion @vdevauxchupin ?

betolink commented 9 months ago

yeah another thing I just noticed is that the github action is installing some packages from source, it would be better to use https://github.com/marketplace/actions/setup-micromamba with our new environment file. I can open a new PR on Monday.

e-marshall commented 9 months ago

Ok cool! Thanks so much Luis! I was able to successfully build a jupyter book with an env created by the new file but still figuring out the github pages issue. Going to merge this now though. Thank you so much for your help with this!