vdggvdgg / winetricks

Automatically exported from code.google.com/p/winetricks
0 stars 0 forks source link

Version 20150114 fails first download of installers every time #472

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Run winetricks, select a prefix, select 'Install DLLs...'
2. Choose one or more installers.
3. click 'OK'.

What is the expected output? 
DLL/installers will start downloading, then run the installers.

What do you see instead?
DLL/installers download, winetricks claims the checksums don't match, and 
downloads a second time, then runs the installer.

What version of the product are you using? 
20150114

On what operating system?
Fedora 20

Please provide any additional information below.
If the file exists in the download cache, winetricks claims the (previously 
downloaded and run) installer doesn't match the checksum, the file will be 
downloaded again, with a second notice of checksum error, then downloaded a 
second time. (This last download is actually the 4th download, two downloads to 
get it in the cache, two more to get it a second time.)

Original issue reported on code.google.com by dosboss...@gmail.com on 5 Feb 2015 at 11:17

GoogleCodeExporter commented 8 years ago
What I saw on OS X is in 
https://code.google.com/p/winetricks/issues/detail?id=473.

If the file doesn't exist in the cache before, A file not found error pops up.

Original comment by arthur200126 on 6 Feb 2015 at 4:11

GoogleCodeExporter commented 8 years ago
After testing, seems this started at 83f0e3d34759.

Original comment by Shannon....@gmail.com on 6 Feb 2015 at 1:52

GoogleCodeExporter commented 8 years ago
Seems the call to w_get_sha1sum doesn't include the winetricks cache path, only 
the installer executable name. Adding that in seems to fix the problem for me.. 
Please verify.

To test, try installing something with the attached modified copy of 
winetricks, vlc for example:
 ./winetricksfixsha1sum -q vlc

Also attached a fix, if it's worthy.

Cheers!

Original comment by Shannon....@gmail.com on 6 Feb 2015 at 2:16

Attachments:

GoogleCodeExporter commented 8 years ago
This issue was closed by revision f98739ad207b.

Original comment by austinenglish@gmail.com on 6 Feb 2015 at 6:26

GoogleCodeExporter commented 8 years ago
Issue 473 has been merged into this issue.

Original comment by austinenglish@gmail.com on 6 Feb 2015 at 6:27

GoogleCodeExporter commented 8 years ago
Thanks Shannon. I had bisected it, but hadn't looked at the commit in detail 
again yet.

Original comment by austinenglish@gmail.com on 6 Feb 2015 at 6:28

GoogleCodeExporter commented 8 years ago
I tried the VLC install command line as you proposed above.  
The first time it downloaded without checksum error and installed correctly.  
Then I deleted the VLC wineprefix (using winetricks) and did the install 
command line again, and it picked the installer file up from the cache and 
installed.
Looks like that fixed it, thanks for the quick fix! 

Original comment by dosboss...@gmail.com on 7 Feb 2015 at 1:50