vdobrovolskii / wl-coref

This repository contains the code for EMNLP-2021 paper "Word-Level Coreference Resolution"
MIT License
103 stars 37 forks source link

some confusions about convert_to_head.py #27

Closed leileilin closed 2 years ago

leileilin commented 2 years ago

Hello, I have a new question about convert to heads.py file, in which some span and clusters will be deleted. Is this the case as follows? In those cases "A" and "A & B" are different spans with the same head word, "A". In our implementation such cases were simply discarded from the training set, because they were few and we were able to perform well, even though we couldn't predict any of such cases during inference. like u said in #2 thanks.

vdobrovolskii commented 2 years ago

I am sorry, I don't quite understand your question. Are you asking if what I said in issue #2 is true? Yes, it is

leileilin commented 2 years ago

I am sorry, I don't quite understand your question. Are you asking if what I said in issue #2 is true? Yes, it is

I mean the deleted span and clusters in convert_to_head.py is the same as the above example i proposed?

vdobrovolskii commented 2 years ago

What example are you referring to?

leileilin commented 2 years ago

In those cases "A" and "A & B" are different spans with the same head word, "A". In our implementation such cases were simply discarded from the training set, because they were few and we were able to perform well, even though we couldn't predict any of such cases during inference.

In those cases "A" and "A & B" are different spans with the same head word, "A". In our implementation such cases were simply discarded from the training set, because they were few and we were able to perform well, even though we couldn't predict any of such cases during inference. it is the example you refered to in #2 .

vdobrovolskii commented 2 years ago

But what do you want me to say? You are quoting me to myself, do I need to additionally confirm what I said is still true? Or what? 😆

leileilin commented 2 years ago

But what do you want me to say? You are quoting me to myself, do I need to additionally confirm what I said is still true? Or what? 😆

what i want to say is the deleted span and clusters in convert_to_head.py is the same as the above example i proposed? i know the example is true but the relationship between them is not certain for me. 😆

vdobrovolskii commented 2 years ago

You mean, is there any difference between deleting a span and deleting a cluster? Or you are talking about the variables deleted_spans and deleted_clusters in convert_to_heads.py?

leileilin commented 2 years ago

You mean, is there any difference between deleting a span and deleting a cluster? Or you are talking about the variables deleted_spans and deleted_clusters in convert_to_heads.py?

I mean, I don't know the basis for deleting span and clusters in convert_to_head.py? is the same as the example above?

leileilin commented 2 years ago

You mean, is there any difference between deleting a span and deleting a cluster? Or you are talking about the variables deleted_spans and deleted_clusters in convert_to_heads.py?

I mean, I don't know the basis for deleting span and clusters in convert_to_head.py? is the same as the example above?

simplly to say , according to what to delete span and cluster in convert_to_head.py?

vdobrovolskii commented 2 years ago

Yes, according to that you would delete spans. And then all the singleton clusters also get deleted.

leileilin commented 2 years ago

Yes, according to that you would delete spans. And then all the singleton clusters also get deleted.

in other words, if "A" and "A & B" are different spans with the same head word, "A". so "A & B" will be deleted. right ?

vdobrovolskii commented 2 years ago

yes

leileilin commented 2 years ago

yes

If I don't delete it, can I train with such a dataset?

vdobrovolskii commented 2 years ago

You can, but it will be suboptimal (you will have the same head point to differen spans in span predictor module). And you will need to merge unrelated clusters.