search

vdorie / treatSens

15 stars 5 forks source link

unfixed error #5

Closed siynsun closed 8 years ago

siynsun commented 8 years ago

Hi Vince, I have tested for various combinations. From me, everything works fine except for the weight parameter "trim.wt". There is no error or warning returns when the weight input is invalid. It happens both on continuous and binary treatment. I am not sure if it is necessary to fix it.

vdorie commented 8 years ago

When we fix this, we should probably only complain if weights are set, and otherwise issue a warning when trim.wt is not missing.

vdorie commented 8 years ago

Updated treatSens and the tests, should be fixed now.