vdr-projects / vdradmin-am

This is the "VDRAdmin-AM" a web user interface for VDR.
GNU General Public License v2.0
2 stars 4 forks source link

some file containing German Umlauts are still ISO-8859-1 encoded #7

Open pbiering opened 1 year ago

pbiering commented 1 year ago

as mostly all systems nowadays are UTF-8 ready, shouldn't the files which contain German Umlaus not be converted?

file -i * | egrep '(utf|iso)'
CREDITS:                  text/plain; charset=iso-8859-1
HISTORY:                  text/plain; charset=iso-8859-1
vdradmind.pl:             text/x-perl; charset=iso-8859-1

Comments?

This is also related to https://github.com/glenvt18/vdradmin-am/pull/9 which has partial replacements already inside, mostly on comments, but one line is affecting the code:

-            unless ($c =~ /[<F6><E4><FC><DF><D6><C4><DC>A-Za-z0123456789_!@\$%&()+,.\-;=~ ]/) {
+            unless ($c =~ /[öäüßÖÄÜA-Za-z0123456789_!@\$%&()+,.\-;=~ ]/) {
MegaV0lt commented 1 year ago

Is there a way to change this automatically?

M-Reimer commented 1 year ago

https://perldoc.perl.org/utf8

You have to tell the interpreter that you plan to use UTF-8 in source code.

pbiering commented 1 year ago

I will take care of this after further testing