search

vdshb / rsocket-java-logger

logger for rsocker-java
Apache License 2.0
0 stars 0 forks source link

Logging #1

Open OlegDokuka opened 4 years ago

OlegDokuka commented 4 years ago

Great work. Just wondering if you have ever looked at https://github.com/rsocket/rsocket-java/blob/develop/rsocket-core/src/main/java/io/rsocket/frame/FrameUtil.java#L11.

Guessing it can simplify your tool a little bit.

Also, we do some logging on the connection level as well.

Please take a look at -> https://github.com/rsocket/rsocket-java/blob/develop/rsocket-core/src/main/java/io/rsocket/internal/ClientServerInputMultiplexer.java#L47

https://github.com/rsocket/rsocket-java/blob/develop/rsocket-core/src/main/java/io/rsocket/internal/ClientServerInputMultiplexer.java#L196

vdshb commented 4 years ago

Thanks for mentioning! I'm not too fast at tracking github issues, as you can see. (I'm actually pretty surprised someone took a glance at this repo.)

FrameUtil is highly useful. I used it to log frames: https://github.com/vdshb/rsocket-java-logger/blob/2e2eb04cac722eadf989efbe66ab67087de8564b/src/main/kotlin/pro/vdshb/rsocket/logger/ByteBufLogger.kt#L22

The way of logging by changing "io.rsocket.FrameLogger" is something I haven't mentioned. I would have used it at the first place if I was more attentive. Not many differences with what this interceptor does.