search

vdudouyt / stm8flash

program your stm8 devices with SWIM/stlinkv(1,2)
GNU General Public License v2.0
402 stars 182 forks source link

added serial, stm8L ROP handling #103

Closed lkord closed 5 years ago

lkord commented 6 years ago

stm8L ROP handling with no BROWNOUT settings distinct serial for stlinksv2 fix

spth commented 6 years ago

IMO, "serial" could be confusing since it is a rather general term, and could e.g. refer to some serial protocol. This makes the code and help output harder to understand. I suggest to use that more clearly refers to a serial number (maybe use "serialno") instead.

Philipp

lkord commented 6 years ago

@spth what about "iSerial"? That is the descriptor from usb info

spth commented 6 years ago

We currently don't have camelCase variable names; I guess for the help output iSerial could be fine, while the variable could be i_serial or so.

Philipp

spth commented 6 years ago

Also, could you add your position on the license change (GPLv2 only vs. GPLv2 or later) in the file "LICENSE-CHANGE"?

Philipp

lkord commented 6 years ago

@spth Could You check this conflicting file? It is just the LICENSE file.