Closed martonmiklos closed 6 years ago
Thanks for implementing this. I have a few remaining questions:
1) Could you indicate if you agree to the GPLv2 -> GPLv2+ license change in the file LICENSE-CHANGE? 2) Antonio Borneo mentioned something about a "new command for version check" that stm8flash would need. Do we need it? If yes, where is it implemented? 3) I suggest to use the name "stlinkv21" in stead of "stlinkv2.1". ST documentation calls it "ST-LINK/V2-1", so stlinkv21 seems more consistent with the naming of the other variants. 4) I assume your test was done using STLINK-V3. I will test using ST-LINK/V2-1 later today today or on Tuesday.
Philipp
Hello Phillipp
I agree, where do I need to indicate this?
I do not think that it is necessary for the stm8flash since the user explicitly specifies the programmer type. BTW. For long term I would recommend to adopt the code from OpenOCD. We could get rid from the magic constants, and we could have a single stlink programmer option with a single C file.
Agree, commit ammended.
Correct, I do not have any boards with ST-Link/V2-1 at hand so I would thank you for the testing.
Since the ST-LINK/V2-1 and STLINK-V3 are handled like the ST-LINK/V2, we should probably also change those lines in the README:
Support table
-------------
* ST-Link V1: flash/eeprom/opt
* ST-Link V2: flash2/eeprom2/opt2
to something like
Support table
-------------
* flash/eeprom/opt: ST-LINK/V1
* flash2/eeprom2/opt2: ST-LINK/V2, ST-LINK/V2-1 and STLINK-V3
Philipp
Writing the flash of the STM8L152R8 via ST-LINK/V2-1 worked, too (you might want to add the ok entry in the README).
Philipp
License change, README and the supported devices table updated.
Add support for the STLinkV3. This device uses the same protocol as the STLinkV2 just uses a different endpoint.
The STLink V2.1 can be found on newer Nucleo boards, it uses the same endpoint as the STLinkV3.
Many thanks to Antonio Borneo (who contributed the STLinkV3 support to the OpenOCD) for the help and hints!
Tested by reading and writing a STM8S003F3 board.
Fixes #90