search

ve12sus / threeway

Custom Squarespace template
0 stars 0 forks source link

Blog Posts - Local / National needs to be dynaimc #30

Closed dansprout closed 6 years ago

dansprout commented 6 years ago

The blog posts are being given local categories but they are not pulling properly. Also, the filtering is not working.

chufucious commented 6 years ago

@ve12sus i can create the tags in CSS or images. Let me know.

ve12sus commented 6 years ago

Filtering and local/national tags now working correctly, except on posts past the 12th. Problem caused by maximum posts displayed resetting to default (after we changed to 2000) will need to reload all blogs, but probably save till the later.

ve12sus commented 6 years ago

I didn't mean to close this issue until pageSize 2000 and reload blog is done.

chufucious commented 6 years ago

The tags still need to be either in CSS or retina images

chufucious commented 6 years ago

I've created a new issue to track the necessity to update tags

https://github.com/ve12sus/threeway/issues/42

ve12sus commented 6 years ago

Eric right now the code chooses an img src depending on if it finds local or national. I think it would be easiest to give me 2x retina images.

ve12sus commented 6 years ago

this is done/fixed. Please check.

chufucious commented 6 years ago

@ve12sus these assets aren't @2x.

for example: https://static1.squarespace.com/static/ta/5a32e53c01002778af38fed2/107/assets/tag-food.png

the file you should be looking for from Zeplin should be called tag-food@2x.png

let me nkow if u need help pulling them from Zeplin

additinoally, we should avoid merging unless we are certain the issue is solved, usually after we approve a change / close a ticket

chufucious commented 6 years ago

Fixed!