@ve12sus: i recommend reviewing my changes when you have time. click on Files changed and then don't forget to click the Load diff link to see all the changes..
notes:
[ ] We need to check for flexbox ie11 support. i left a jeff todo comment in the file.
don't use divs unless absolutely necessary. you can target HTML elements within (h2, img, etc) vs making another container to target
don't fight css! learn how it can work for you. with css, less is more.
again, DRY. i made a ad-2-10 general class that took care of the rmhc and mcdapp ads. i made specific classes for those for individual styling like colors and image behaviors
HTML will most likely never look exactly like JPG/bitmaps. designs will always look different. you will learn this over time
you were making media queries that ended up just complicating things. i deleted most of them. combining min-width and max-width can get super confusing, especially if you have odd breakpoints like 992px
lots of fixes for ads.
@ve12sus: i recommend reviewing my changes when you have time. click on
Files changed
and then don't forget to click theLoad diff
link to see all the changes..notes:
jeff todo
comment in the file.ad-2-10
general class that took care of the rmhc and mcdapp ads. i made specific classes for those for individual styling like colors and image behaviorsmin-width
andmax-width
can get super confusing, especially if you have odd breakpoints like992px