search

ve3wmb / OrionWspr

Arduino WSPR Beacon for Amateur Radio pico-Balloons using SI5351a
GNU General Public License v3.0
16 stars 5 forks source link

OrionBoardConfig.h - clock speed dependent parameters should be defined based on F-CPU value #4

Open ve3wmb opened 5 years ago

ve3wmb commented 5 years ago

In OrionBoardConfig.h the defined parameters WSPR_CTC and SI5351_CAL_TARGET_FREQ should have their values set automatically based on the value of F_CPU (defined within the Arduino Board definition files). (i.e. #if F_CPU == 8000000L ). This makes the code more portable as most Arduinos run at 16 Mhz (i.e. F_CPU == 16000000L) whereas the Pro Mini runs at 8 Mhz.

This is a low priority but raising this as an issue ensures that it doesn't get lost.

ve3wmb commented 4 years ago

This is not a priority for the first release but I will leave it open for future consideration. The actual effort is small but would require significant testing and it is not needed for Release 1.