veandco / go-sdl2

SDL2 binding for Go

https://godoc.org/github.com/veandco/go-sdl2

BSD 3-Clause "New" or "Revised" License

2.22k stars 223 forks source link

sdl: audio: Remove *AudioSpec parameter from LoadWAV() and LoadWAVRV() #309

Closed malashin closed 6 years ago

malashin commented 6 years ago

308

Removed *AudioSpec parameter from LoadWAV() and LoadWAVRW().

They were passed in C only to be filled in with metadata. Now empty AudioSpec struct is created inside the binding function, passed to C and returned to the user with all relevant info.

We will need to update the examples if this is accepted.

veeableful commented 6 years ago

Looks good. Thanks @malashin!

Seeing you contribute so much, I want to ask if you would consider being a Github contributor the project? That way you don't always have to go through me when the changes are simple =)

malashin commented 6 years ago

@veeableful Yeah, sure. I'll most likely still PR all the changes, just accept the simple ones myself.

veeableful commented 6 years ago

@malashin Cool! I've sent you the invite.