Making go-sdl2 a bit more compatible with Go standard libraries

veandco / go-sdl2

SDL2 binding for Go

https://godoc.org/github.com/veandco/go-sdl2

BSD 3-Clause "New" or "Revised" License

2.2k stars 218 forks source link

Making go-sdl2 a bit more compatible with Go standard libraries #369

Closed akiross closed 5 years ago

akiross commented 5 years ago

This PR does 3 things:

changes sdl.Color to image/color.RGBA, which is alpha-premultiplied 32 bit RGBA color; this makes sdl.Color compatible with color.Color.
makes sdl.Surface compatible with image.Image and draw.Image, adding few methods that can be used to retrieve the surface color model and get/set pixels at a specified position.
introduces a raster subdirectory with an implementation of a freetype painter that should work on any Image (therefore, also sdl.Surfaces). This allows to 3rd party packages to draw over sdl.Surface if they make use of freetype painters (e.g. llgcode/draw2d).

This should not break anything, but since sdl.Color changed, more testing on this should be performed.

veeableful commented 5 years ago

Thanks! Looks alright. If it's not too much trouble, would you fix the Hound issues and remove the code comments? After that, it should be good to be merged!

akiross commented 5 years ago

Sure, I'll fix those issues as soon as I can!

akiross commented 5 years ago

Ok, I updated the code and resolved the style issues :) Testing is welcome!

veeableful commented 5 years ago

@akiross Thanks! Sorry to bother you again but is the comment at https://github.com/veandco/go-sdl2/pull/369/files#diff-b4dd330e72a392d1e6e87ac03a919716R550 supposed to be there?

akiross commented 5 years ago

Yes, it is supposed to be there because I did not test it yet. I'll try to update the code and support other surface formats in the future.

veeableful commented 5 years ago

No worries! I'm really grateful for the work since it makes up for my lack of contributions recently :stuck_out_tongue:

I'm merging it in then. Thanks again for your hard work!