search

veandco / go-sdl2

SDL2 binding for Go
https://godoc.org/github.com/veandco/go-sdl2
BSD 3-Clause "New" or "Revised" License
2.2k stars 218 forks source link

fix img/sdl_image_test.go #370

Closed kjx98 closed 5 years ago

kjx98 commented 5 years ago

fix call sdl.RWFromMem for img/sdl_image_test.go only

veeableful commented 5 years ago

Hi @kjx98, the change is too big for me to merge. Could you narrow it down to commits that only fixes the sdl_image_test.go please? Maybe create another branch that contains only the fix and use that for the pull request. I would really appreciate it!

sk4r commented 5 years ago

@kjx98 it would help if you could describe the problem this is fixing in the pull request description. Also it does seem to include extra commits specific to your fork, that shouldn't be in master.

kjx98 commented 5 years ago

sorry for inconvenience. I just fixed img/sdl_image_test.go for sdl.RWFromMem call which need two param

kjx98 commented 5 years ago

since I only need sdl core package, I strip even img package to keep sdl only.

kjx98 commented 5 years ago

Hi @kjx98, the change is too big for me to merge. Could you narrow it down to commits that only fixes the sdl_image_test.go please? Maybe create another branch that contains only the fix and use that for the pull request. I would really appreciate it!