search

veandco / go-sdl2

SDL2 binding for Go
https://godoc.org/github.com/veandco/go-sdl2
BSD 3-Clause "New" or "Revised" License
2.2k stars 218 forks source link

fix RWFromMem of sdl/audio_test.go #376

Closed kjx98 closed 5 years ago

kjx98 commented 5 years ago

test: fix same BUG in sdl/audio_test.go RWFromMem with []byte param only

kjx98 commented 5 years ago

add go test script to test sdl subsystem

veeableful commented 5 years ago

Hi @kjx98, thanks for your contributions! Could you separate the changes to different pull requests? Right now it has CI and test code changes which are not related.

Although, the reason we use SDL2 2.0.0 is because we want to make sure the binding is still usable on older version. I believe Xenial has SDL2 2.0.4. Other than that, I think any kind of improvement to the CI is welcome!

kjx98 commented 5 years ago

Hi, @veeableful I've reversed CI patch, only test patch left.

veeableful commented 5 years ago

Sorry for getting back so late! I've merged your pull request. Thanks!