veandco / go-sdl2

SDL2 binding for Go
https://godoc.org/github.com/veandco/go-sdl2
BSD 3-Clause "New" or "Revised" License
2.2k stars 218 forks source link

Sensor.Close calls SDL_SensorGetNonPortableType #378

Closed gonutz closed 5 years ago

gonutz commented 5 years ago

The implementation of Sensor.Close calls SDL_SensorGetNonPortableType. It should probably be calling SDL_SensorClose right?

This is the same thing that happened in #377. I am currently going through your whole API, removing the CGo from the Windows port by loading the DLL and calling it directly rather than going through the C layer. I am almost done and will be opening a large pull request soon. Maybe I find some more of these along the way :-)

veeableful commented 5 years ago

Thanks for catching this! I've fixed it in master branch.

gonutz commented 5 years ago

OK, closing this as well.