veandco / go-sdl2

SDL2 binding for Go
https://godoc.org/github.com/veandco/go-sdl2
BSD 3-Clause "New" or "Revised" License
2.2k stars 218 forks source link

Merges .go-sdl2-libs as part of the repository #392

Closed veeableful closed 5 years ago

veeableful commented 5 years ago

This fixes static and/or cross-platform build when using the new Go Module system as it doesn't fetch the (previously) sub-module go-sdl2-libs.

I thought that this is straightforward but perhaps it's good to have an okay from @gen2brain. I should not have asked him to make it into sub-module :joy_cat:

gen2brain commented 5 years ago

Hi,

Sure, this is fine, a simple change. It does add some weight in MB to the repo, but that should not be a big issue. I planned to add libs for linux/arm separated with tags for generic GLES, RPi and vivante video drivers, that will probably add another 3-5M to repo, but is nice to have. Currently, linux/arm will just assume RPi.

veeableful commented 5 years ago

Yeah, it will add quite a bit to the Git repo. I'm hopeful that since Go is making the Module system the default in Go 1.13, users won't notice the difference since they're going to download only the files without history :grin:

Alright then, I'm merging it!