search

veandco / go-sdl2

SDL2 binding for Go
https://godoc.org/github.com/veandco/go-sdl2
BSD 3-Clause "New" or "Revised" License
2.17k stars 219 forks source link

mix: Added binding to Mix_OpenAudioDevice #454

Closed exopulse closed 4 years ago

exopulse commented 4 years ago

Method Mix_OpenAudioDevice (unlike Mix_OpenAudio) allows device to be specified.

veeableful commented 4 years ago

Hi @exopulse, thank you for the binding! I believe the constants have already been defined in the sdl package or is there a reason that you added them?

exopulse commented 4 years ago

Hi @veeableful, I was just tying those more closely to the mix package. I can ditch those and stick to the sdl package constants if that is the preferred way.

veeableful commented 4 years ago

Hi @exopulse, are you perhaps not using the sdl package? I can see why you don't want to add another dependency if that is the case. Otherwise, I think they are not necessary (but definitely let me know if you have some use-case!).

exopulse commented 4 years ago

Hi @veeableful, you are right. I am using the sdl package and will remove these constants in favor of the existing ones. Thanks!

veeableful commented 4 years ago

I see. Thank you for making the change!