static: remove -Wl,--no-undefined from ldflags. Go 1.17 will have sup…

veandco / go-sdl2

SDL2 binding for Go

https://godoc.org/github.com/veandco/go-sdl2

BSD 3-Clause "New" or "Revised" License

2.17k stars 219 forks source link

static: remove -Wl,--no-undefined from ldflags. Go 1.17 will have sup… #481

Closed Keithcat1 closed 3 years ago

Keithcat1 commented 3 years ago

…port for linking with LLVM lld, but LLD its self doesn't accept --no-undefined

veeableful commented 3 years ago

Hi @Keithcat1, thanks for submitting the pull request! Could you explain why we need to remove the flag? Is Go going to use LLD as the default linker? If so, could you please share the links?

Otherwise, perhaps this can be implemented via a build tag?

Keithcat1 commented 3 years ago

LLD won't become the default linker for GO as far as I know, however I like to use it because it speeds up compilation times. --no-undefined needs to be removed because LLD crashes if it gets this flag. See #464

veeableful commented 3 years ago

Ahh I see. If @gen2brain said it's okay, then I will merge this pull request. Thanks for bringing the old issue back into attention! I will also back-port this back to v0.4.x.