veandco / go-sdl2

SDL2 binding for Go
https://godoc.org/github.com/veandco/go-sdl2
BSD 3-Clause "New" or "Revised" License
2.17k stars 219 forks source link

Align colors in SDL package to Go specification #581

Closed mokiat closed 7 months ago

mokiat commented 7 months ago

Closes https://github.com/veandco/go-sdl2/issues/580

This PR does the following changes:

Things to note:

Side notes:

mokiat commented 7 months ago

This PR should be ready for a more general public verification. The more people that have color scenarios in their apps to verify the better.

veeableful commented 7 months ago

Thank you very much @mokiat! I will merge this into the v0.4.x branch and create a new patch release as well so more people can test it.

mokiat commented 7 months ago

Thanks! Using v0.4.36, colors work well for me now.

On a side note, asking for future reference: should I have opened the PR against v0.4.x or was master ok, since there seem to be other API changes in master (e.g. non-ptr events) that have not gone into v0.4.x?

veeableful commented 7 months ago

Yes, master is preferred in most cases. I usually cherry-pick the commit into v.4.x branch afterwards. (Speaking of, I really should get v0.5.x out already 😓, just stuck on the static libraries currently).