vearutop / plt

⏱️ Pocket load tester
MIT License
48 stars 3 forks source link

Disable http3 for go1.20+ #30

Closed vearutop closed 1 year ago

github-actions[bot] commented 1 year ago

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
Go 16 (+2) 2013 (+28) 1576 (+14) 63 (+4) 374 (+10) 271 (+1) 52.3K (+375B)
Makefile 1 44 32 4 8 2 1.3K (-1B)
YAML 8 584 (+3) 497 (+3) 43 44 0 19.5K (+58B)
github-actions[bot] commented 1 year ago

Go API Changes

# github.com/vearutop/plt/nethttp
## compatible changes
HTTP3Available: added

# summary
Inferred base version: v0.3.7
Suggested version: v0.4.0
github-actions[bot] commented 1 year ago

Benchmark Result

Benchmark diff with base branch ``` name old time/op new time/op delta pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64 JobProducer_Job-2 20.7µs ±12% 20.6µs ± 2% ~ (p=0.310 n=5+5) pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64 JobProducer_Job-2 1.00ms ± 0% 1.00ms ± 0% ~ (p=0.222 n=5+5) name old alloc/op new alloc/op delta pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64 JobProducer_Job-2 1.84kB ± 0% 1.84kB ± 0% ~ (p=0.786 n=5+5) pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64 JobProducer_Job-2 5.77kB ± 0% 5.78kB ± 0% ~ (p=0.087 n=5+5) name old allocs/op new allocs/op delta pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64 JobProducer_Job-2 26.0 ± 0% 26.0 ± 0% ~ (all equal) pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64 JobProducer_Job-2 86.0 ± 0% 87.0 ± 0% +1.16% (p=0.008 n=5+5) ```
Benchmark result ``` name time/op pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64 JobProducer_Job-2 20.6µs ± 2% pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64 JobProducer_Job-2 1.00ms ± 0% name alloc/op pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64 JobProducer_Job-2 1.84kB ± 0% pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64 JobProducer_Job-2 5.78kB ± 0% name allocs/op pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64 JobProducer_Job-2 26.0 ± 0% pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64 JobProducer_Job-2 87.0 ± 0% ```
github-actions[bot] commented 1 year ago

Unit Test Coverage

total: (statements) 54.8% changed lines: (statements) 0.0%, coverage is less than 90.0%, consider testing the changes more thoroughly

Coverage of changed lines | File | Function | Coverage | |---------------------|----------------|----------| | Total | | 0.0% | | nethttp/http3.go | | 0.0% | | nethttp/http3.go:15 | makeTransport3 | 0.0% |
Coverage diff with base branch | File | Function | Base Coverage | Current Coverage | |------------------------------------------|----------------|---------------|------------------| | Total | | 54.8% | 54.8% (0.0%) | | github.com/vearutop/plt/nethttp/http3.go | makeTransport3 | no function | 0.0% | | github.com/vearutop/plt/nethttp/job.go | makeTransport3 | 0.0% | no function |
codecov-commenter commented 1 year ago

Codecov Report

Base: 47.91% // Head: 47.91% // No change to project coverage :thumbsup:

Coverage data is based on head (f122b69) compared to base (5aacebe). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #30 +/- ## ======================================= Coverage 47.91% 47.91% ======================================= Files 7 8 +1 Lines 599 599 ======================================= Hits 287 287 Misses 270 270 Partials 42 42 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `47.91% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Viacheslav+Poturaev#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/vearutop/plt/pull/30?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Viacheslav+Poturaev) | Coverage Δ | | |---|---|---| | [nethttp/http3.go](https://codecov.io/gh/vearutop/plt/pull/30/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Viacheslav+Poturaev#diff-bmV0aHR0cC9odHRwMy5nbw==) | `0.00% <0.00%> (ø)` | | | [nethttp/job.go](https://codecov.io/gh/vearutop/plt/pull/30/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Viacheslav+Poturaev#diff-bmV0aHR0cC9qb2IuZ28=) | `62.37% <ø> (+1.50%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Viacheslav+Poturaev). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Viacheslav+Poturaev)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.