search

vebr / jest-lcov-reporter

This action comments a pull request with a simple HTML test coverage report.
13 stars 18 forks source link

`update-comment` updates the same comment in reusable workflows #29

Open js-beaulieu opened 2 years ago

js-beaulieu commented 2 years ago

I'm trying to use this in a monorepo, where we have a reusable workflow that does the whole checkout/npm ci/npm run <command> etc. shenanigans.

Unfortunately, the update-comment option doesn't seem to play well with reusable workflows. Looking at the code, it's looking for a comment containing <!-- Code Coverage Comment: <workflow name> -->. I feel like it should probably use the optional name input if provided rather than the workflow name, as this means different test suites end up overwriting each other.

nevercast commented 4 months ago

Thanks for mentioning this, @js-beaulieu - it made it very quick to find.