search

vechain / connex

The mono-repo contains libraries to help build dApps for VeChain.
https://docs.vechain.org/developer-resources/sdks-and-providers/connex
GNU Lesser General Public License v3.0
85 stars 3.6k forks source link

Fix lint issue #150

Closed fabiorigam closed 1 year ago

fabiorigam commented 1 year ago

Hello, I hope you're doing well. Previously, the lint script in the package.json was using TSLint to check the TypeScript files (and was not working). We are now using ESLint command instead. This is a positive change since ESLint is widely adopted and provides more extensive configuration options and plugin support. It will help maintain a consistent and clean codebase.

libotony commented 1 year ago

Thank you for the contribution, there was a history that changing the lint tool from tslint to eslint. Eslint works perfectly with eslint plugin installed with vscode. I made a test locally, looks like eslint does not working properly, it can not recognize the right tsconfig file, I think it might need some extra settings for monorepo.

fabiorigam commented 1 year ago

Dear @libotony Thank you for your invaluable feedback and the information you've provided. After careful consideration, we've decided to close this pull request without merging it. Best regards, Fabio & Rodolfo