vechain / node-healthcheck

A healthcheck API for vechain nodes (deprecating)
https://bit.ly/node-hosting
MIT License
1 stars 1 forks source link

Implement v1 of the healthcheck and create github files for open source #1

Closed kgapos closed 1 year ago

github-advanced-security[bot] commented 1 year ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

kgapos commented 1 year ago

The code in the src folder has no comments. We need to add comments to make the code clearer. I can add them, let me know :)

Clean, readable code is usually enough to convey the intention. Failing that, comments are welcome. We also don't have any unit tests, but there's not much business logic here to be tested. Still, I had to relax the SonarCloud quality gate in order to accept a 0% unit test code coverage. Contributions in comments and tests are welcome anytime @fabiorigam, thank you in advance!

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication