feat: Add coverage for wrong cases of derive private key, signature, recovery

vechain / thor-devkit.js

Typescript library to aid DApp development on VeChain Thor

MIT License

39 stars 30 forks source link

feat: Add coverage for wrong cases of derive private key, signature, recovery #58

Closed rodolfopietro97 closed 1 year ago

rodolfopietro97 commented 1 year ago

Greetings again, team. I have created the following pull request aiming to enhance the code coverage of the secp256k1 tests. Specifically, the proposed modifications target two instances:

Wrong case of derivePublicKey
Wrong cases of signature
Wrong cases of recovery

These amendments aim to improve the robustness and reliability of our bloom filter tests, ensuring a more comprehensive evaluation of its performance and functionality.

Code coverage BEFORE:

Code coverage AFTER:

qianbin commented 1 year ago

It‘s helpful. Thanks.

coveralls commented 1 year ago

coverage: 92.925% (+1.6%) from 91.293% when pulling 5cc79629572364a050f73b13db08bdc358ae981e on rodolfopietro97:increase-code-coverage-secp256k1 into b35914b5da547628895c627ab6b3abc72264ffef on vechain:master.