vechain / thor-devkit.js

Typescript library to aid DApp development on VeChain Thor
MIT License
39 stars 30 forks source link

Ethers and ts refactor #60

Open rodolfopietro97 opened 1 year ago

rodolfopietro97 commented 1 year ago

Dear Esteemed Team Members,

I hope this message finds you well. It is my pleasure to announce that a new pull request has been created, targeting to enhance the project by upgrading the Typescript version and the Ethers. The goal has been pursued by substituting vechain/ethers with the most recent version of ethers. A few lines have also been replaced by web3.

Please Note: In a bid to validate the new modifications and ensure that no regression bugs are introduced, I have incorporated some regression tests into this pull request. You may execute these tests by running the following command: npm run test:regression_check.

It's worth mentioning that the aforementioned tests are currently temporary, and can be removed or maintained based on our collective decision. Kindly review the pull request at your earliest convenience and make a decision on whether to approve the changes or not. If approved, we can further deliberate on whether to remove these tests or keep them in place for possible future modifications.

Looking forward to hearing your constructive feedback. Thank you in advance for your time and attention.

Best Regards, Rodolfo

coveralls commented 1 year ago

Coverage Status

coverage: 96.529% (+0.1%) from 96.395% when pulling e77e1c78ad686016720aa29288b6be4c3c62b4fb on rodolfopietro97:ethers-and-ts-refactor into 4fe1b703f60cb7337ca0f7be8ea8c19076be935f on vechain:master.

sonarcloud[bot] commented 1 week ago

Quality Gate Failed Quality Gate failed

Failed conditions
7.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud