Closed darrenvechain closed 3 months ago
@libotony made these changes to ensure proper RC tagging:
Converting to draft for now, looks like on release is targetting master branch on my test repo:
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 57.27%. Comparing base (
e42227b
) to head (417373e
).:exclamation: Current head 417373e differs from pull request most recent head 0b080e6. Consider uploading reports for the commit 0b080e6 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@libotony @otherview I added some release / tag validation in this commit:
https://github.com/vechain/thor/pull/683/commits/bde9b27dcb3f96dcdc6e69d31ee4fa9e68b06fb6
Testing was done here: https://github.com/darrenvechain/docker-publish-testing/actions
LGTM, would mind taking another look @otherview ?
Description
This changes how we publish docker images:
On commit to main:
master-latest
to GitHub Packagesmaster-${date}-${short sha}
to GitHub PackagesOn pre-release:
vX.Y.Z-rc.A
to GitHub PackagesvX.Y.Z-rc.A
to Docker HubOn release:
vX.Y.Z
to GitHub PackagesvX.Y.Z
to Docker Hublatest
to GitHub Packageslatest
to Docker HubFYI For pre-releases, it's important to append the
-rc
and set it as a pre-release:Type of change
How Has This Been Tested?
Please refer to the last 4 workflows here: https://github.com/darrenvechain/docker-publish-testing/actions
Checklist: