vechain / thor

A general purpose blockchain highly compatible with Ethereum's ecosystem
GNU Lesser General Public License v3.0
795 stars 248 forks source link

Enable custom ghcr images #683

Closed darrenvechain closed 3 months ago

darrenvechain commented 3 months ago

Description

This changes how we publish docker images:

  1. On commit to main:

    • Publish master-latest to GitHub Packages
    • Publish master-${date}-${short sha} to GitHub Packages
  2. On pre-release:

    • Publish vX.Y.Z-rc.A to GitHub Packages
    • Publish vX.Y.Z-rc.A to Docker Hub
  3. On release:

    • Publish vX.Y.Z to GitHub Packages
    • Publish vX.Y.Z to Docker Hub
    • Publish latest to GitHub Packages
    • Publish latest to Docker Hub

FYI For pre-releases, it's important to append the -rc and set it as a pre-release:

image

Type of change

How Has This Been Tested?

Please refer to the last 4 workflows here: https://github.com/darrenvechain/docker-publish-testing/actions

Checklist:

darrenvechain commented 3 months ago

@libotony made these changes to ensure proper RC tagging:

https://github.com/vechain/thor/compare/db68a5f...e6ef848

darrenvechain commented 3 months ago

Converting to draft for now, looks like on release is targetting master branch on my test repo:

image
codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.27%. Comparing base (e42227b) to head (417373e).

:exclamation: Current head 417373e differs from pull request most recent head 0b080e6. Consider uploading reports for the commit 0b080e6 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #683 +/- ## ======================================= Coverage 57.27% 57.27% ======================================= Files 156 156 Lines 17218 17218 ======================================= Hits 9862 9862 Misses 6392 6392 Partials 964 964 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

darrenvechain commented 3 months ago

@libotony @otherview I added some release / tag validation in this commit:

https://github.com/vechain/thor/pull/683/commits/bde9b27dcb3f96dcdc6e69d31ee4fa9e68b06fb6

Testing was done here: https://github.com/darrenvechain/docker-publish-testing/actions

libotony commented 3 months ago

LGTM, would mind taking another look @otherview ?