Closed darrenvechain closed 2 months ago
Attention: Patch coverage is 94.87179%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 61.64%. Comparing base (
0489d6a
) to head (7d7f067
). Report is 3 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
api/api.go | 0.00% | 2 Missing :warning: |
api/utils/revisions.go | 93.93% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Add finalized to:
Add documentation clarifying what finalized means:
Add finalized to:
- transactions endpoint
- debug trace call endpoint
Add documentation clarifying what finalized means:
- 360 blocks
- 2 rounds of BFT
Had a discussion with @darrenvechain, transaction's endpoint does not need finalized
, it used to only accept blockID or null
Do not forget to sync the version thor.yaml
with cmd/thor/VERSION
@darrenvechain since we got changes in the API spec
Description
This PR allows clients to specify
finalized
as a revision on the accounts endpoints.The solo instance is also modified to return the best block as the finalized block
Type of change
How Has This Been Tested?
accounts_test.go
Checklist: