darrenvechain commented 3 months ago

Description

This change allows injection of a master key as a startup flag

Fixes # (issue)

Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

./bin/thor --network main --master-key eb5cce9a3ba17cd90fd4238cb382d1c47f1c2084f71384f6de6da03a1582d5e6

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] New and existing E2E tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have not added any vulnerable dependencies to my code

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.27%. Comparing base (c9c4a51) to head (d640297).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #690 +/- ## ======================================= Coverage 57.27% 57.27% ======================================= Files 156 156 Lines 17218 17218 ======================================= Hits 9862 9862 Misses 6392 6392 Partials 964 964 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kgapos commented 3 months ago

@darrenvechain looks good, you may want to document it in the docs?