vechain / thor

A general purpose blockchain highly compatible with Ethereum's ecosystem
GNU Lesser General Public License v3.0
791 stars 247 forks source link

Builtin coverage #736

Closed ahasikos closed 1 month ago

ahasikos commented 1 month ago

Description

Increases test coverage of the builtin package and specifically:

Fixes #190

Type of change

Adds code coverage tests

How Has This Been Tested?

make test

Test Configuration:

Checklist:

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.67%. Comparing base (4fa7366) to head (169b35f). Report is 6 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #736 +/- ## ========================================== + Coverage 61.36% 61.67% +0.31% ========================================== Files 194 195 +1 Lines 18223 18246 +23 ========================================== + Hits 11182 11253 +71 + Misses 5959 5897 -62 - Partials 1082 1096 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ahasikos commented 1 month ago

@paologalligit I agree. We need to decide on how we exclude either functions or files from being tested.

libotony commented 1 month ago

@paologalligit I agree. We need to decide on how we exclude either functions or files from being tested.

Could you remove the generated file's test and let's find a way to improve the codecov strategy?