search

vechain / thor

A general purpose blockchain highly compatible with Ethereum's ecosystem
GNU Lesser General Public License v3.0
796 stars 247 forks source link

Selectable block interval on solo #740

Closed MakisChristou closed 4 months ago

MakisChristou commented 4 months ago

Tackles the following issue. In this PR I basically added the option to use a command-line argument specifically for solo to allow the developer to choose a custom block interval with a minimum value of 1. I tested it and it looks like its working fine for 1 second block intervals as well as larger intervals like 100 seconds.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 61.77%. Comparing base (95aed69) to head (da56ae5). Report is 5 commits behind head on master.

Files Patch % Lines
cmd/thor/main.go 0.00% 5 Missing :warning:
cmd/thor/solo/solo.go 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #740 +/- ## ========================================== + Coverage 61.64% 61.77% +0.13% ========================================== Files 195 196 +1 Lines 18246 18278 +32 ========================================== + Hits 11247 11291 +44 + Misses 5904 5885 -19 - Partials 1095 1102 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

claytonneal commented 4 months ago

Can we add to the readme please? (useage.md file)