vechain / thor

A general purpose blockchain highly compatible with Ethereum's ecosystem
GNU Lesser General Public License v3.0
791 stars 247 forks source link

remove flaky subscription test #742

Closed paologalligit closed 1 month ago

paologalligit commented 1 month ago

Description

We've had multiple failing tests in ci/cd caused by a timeout while running the subscriptions tests. The issue is not directly reproducible locally and failing runs happen randomly, but the issue seems to be related to the websocket connection not being able to receive a message, so it hangs waiting indefinitely. This PR adds a timeout of 5 seconds: if a message is not received the test is simply skipped.

Fixes issue-199

Type of change

Please delete options that are not relevant.

Checklist:

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.44%. Comparing base (aedfc6b) to head (e52c52c). Report is 14 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #742 +/- ## ========================================== + Coverage 61.77% 62.44% +0.67% ========================================== Files 195 198 +3 Lines 18246 18071 -175 ========================================== + Hits 11271 11285 +14 + Misses 5876 5704 -172 + Partials 1099 1082 -17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.