Closed WaqarAhmedVC closed 4 months ago
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.
Attention: Patch coverage is 55.55556%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 61.88%. Comparing base (
b9047c0
) to head (36e44b6
).
Files | Patch % | Lines |
---|---|---|
cache/rnd_cache.go | 50.00% | 1 Missing :warning: |
cmd/thor/utils.go | 0.00% | 1 Missing :warning: |
comm/peer.go | 0.00% | 1 Missing :warning: |
p2psrv/rpc/rpc.go | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@WaqarAhmedVC we can add gosec to the linters in our lint config:
https://github.com/vechain/thor/blob/master/.golangci.yml#L13
@darrenvechain Thanks for pointing out. I was searching for this info but couldn't find it.
Description
Add gosec to perform Static Application Security Testing (SAST) Analysis.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: