Closed otherview closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 61.88%. Comparing base (
8f2373b
) to head (d195546
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This is weird one.
Linter should be failing for both PR and Master. But it only fails in Master.
When one emulates what github does:
docker run --rm -v $(pwd):/app -w /app golangci/golangci-lint:v1.54.2 golangci-lint run -v
it fails with:Unsure why this does not happen in the PR run
Locally I typically run version 1.55.2 where the linter does not fail.
@leszek-vechain is running version 1.57.2 where the linter does not fail.
My assessment is that something is off in the 1.54.2 version because it technically is not repeating the expected result.
This PR bumps the Linter to 1.55.2 and go to 1.22 (for the linter).
I think as part of the update golang task we should do a bump the linter to latest and upgrade all dev versions to the same version. ie. I'm running go1.22 golangci-lint but running go1.19 for thor.
Fixes # (issue)
Type of change
Checklist: