vechain / thor

A general purpose blockchain highly compatible with Ethereum's ecosystem
GNU Lesser General Public License v3.0
799 stars 248 forks source link

getsummary and getsummaryAndState decoupling #786

Closed otherview closed 1 month ago

otherview commented 1 month ago

Description

Small refactor around getsummary

Fixes # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist:

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 93.68421% with 6 lines in your changes missing coverage. Please review.

Project coverage is 62.65%. Comparing base (bfa83f3) to head (8acb364). Report is 1 commits behind head on master.

Files Patch % Lines
api/utils/revisions.go 90.32% 3 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #786 +/- ## ========================================== + Coverage 62.57% 62.65% +0.08% ========================================== Files 199 199 Lines 18153 18196 +43 ========================================== + Hits 11359 11401 +42 Misses 5713 5713 - Partials 1081 1082 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

libotony commented 1 month ago

LGTM, this will tidy API in revisions.go, thanks!