vechain / thor

A general purpose blockchain highly compatible with Ethereum's ecosystem
GNU Lesser General Public License v3.0
799 stars 248 forks source link

feat: add enable-debug flag #791

Closed YeahNotSewerSide closed 4 days ago

YeahNotSewerSide commented 1 month ago

Description

As default /debug endpoint is disabled on the node, and can be turned on with a supplied flag --enable-debug

issue

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist:

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 62.51%. Comparing base (e6c91cb) to head (f5e0289). Report is 7 commits behind head on master.

Files Patch % Lines
cmd/thor/main.go 0.00% 4 Missing :warning:
api/api.go 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #791 +/- ## ========================================== + Coverage 62.08% 62.51% +0.43% ========================================== Files 203 203 Lines 18723 18732 +9 ========================================== + Hits 11624 11711 +87 + Misses 5997 5923 -74 + Partials 1102 1098 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

darrenvechain commented 1 month ago

@YeahNotSewerSide looks like we need a PR to update the start command in e2e tests.

YeahNotSewerSide commented 1 month ago

@YeahNotSewerSide looks like we need a PR to update the start command in e2e tests.

https://github.com/vechain/thor-e2e-tests/pull/28 - added a flag to the e2e tests

leszek-vechain commented 2 weeks ago

I think we need to modify the tests to have debug enabled too (Darren suggested that)

YeahNotSewerSide commented 1 week ago

I think we need to modify the tests to have debug enabled too (Darren suggested that)

https://github.com/vechain/thor-e2e-tests/pull/28 the pull request for that was open

darrenvechain commented 4 days ago

Closing as we went with a different approach