Closed lucanicoladebiasi closed 1 week ago
Lines | Statements | Branches | Functions |
---|---|---|---|
100% (3430/3430) | 100% (808/808) | 100% (711/711) |
Title | Tests | Skipped | Failures | Errors | Time |
---|---|---|---|---|---|
core | 501 | 0 :zzz: | 0 :x: | 0 :fire: | 1m 6s :stopwatch: |
network | 662 | 0 :zzz: | 0 :x: | 0 :fire: | 4m 16s :stopwatch: |
errors | 48 | 0 :zzz: | 0 :x: | 0 :fire: | 11.416s :stopwatch: |
Description
The re-introduction of previous code to implenemnt tyhe keystore, based on
ethers
reintroduced the sensitive information leak.Fixes private key leak in logs because
assertIsValidPrivateKey
inpackages/core/src/assertions/keystore/keystore.ts
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
yarn test:solo
yarn test:unit
Test Configuration:
Checklist: