🐛 [BUG] - typing for methods is not available when loading a contract

[akanoce]

Description

Looks like some methods of the class returned via

new Contract(....) are not typed, making it difficult to work with such methods, requiring different ts-ignore to silence ts.

As you can see in both screenshots, the Contract is just a generic Contract<Abi>. I tried with multiple abis and contracts achieving the same result

Reproduction URL

No response

Reproduction steps

1. Copy this json and assign it to a variable in your local const abi = [...]
2. Define the contract address const address = "0x89A00Bb0947a30FF95BEeF77a66AEdE3842Fe5B7"
3. Instantiate the thorClient const thorClient = ThorClient.fromUrl("https://mainnet.vechain.org");
4. Instantiate the contract class

   const allocationContract = new Contract(
   address,
   abi,
   thorClient
   );

5. See the errors like attached. No method is available using .read and .clause

Screenshots

No response

Logs

No response

OS

Mac

[Valazan]

There is something odd in the ABI that was provided, if I load the one from the vebetterdao package, the typings works as expected.

@akanoce can you confirm it's still a bug and not a problem with the ABI provided?

[fabiorigam]

Waiting for @akanoce feedback

[akanoce]

@Valazan @fabiorigam it's still not working on my side guys. I tried with lot of different abis, without luck (i.e https://github.com/vechain/b32/blob/master/ABIs/VeBetterDAO-b3tr.json)

• I Updated to beta-26;
• I Performed a clean install;

Also, i really think we should infer the type instead of having the user manually declare it like

Contract<type of json.abi>

which, is trowing type errors in my case

[Valazan]

@akanoce we have to check it better because the type is directly imported from abitype https://abitype.dev/, so it's not something implemented by SDK.

As for the loading, the standard way to load a contract is:

        const loadedContract = thorSoloClient.contracts.load(
            contract.address,
            contract.abi
        );

In this case type will be inferred. But we can also see it implemented also for a new contract object instantiation

[fabiorigam]

Opened a new PR with a releted issue, this one is working