Collect all requirements for eth_getLogs

vechain / vechain-sdk-js

The official JavaScript SDK for VeChain.

24 stars 9 forks source link

Collect all requirements for eth_getLogs #1072

Closed rodolfopietro97 closed 2 months ago

rodolfopietro97 commented 3 months ago

To have 'logIndex' and 'transactionIndex', we need to query a block for each entry into the logs. After from the block, we can get the transaction index and the log index. This is a performance issue because we have to query a block for each entry into the logs. So, the best is to implement it protocol side

rodolfopietro97 commented 3 months ago

@victhorbi

Input and behaviour to eth_getLogs: https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_getlogs
Output of eth_getLogs: https://ethereum.org/en/developers/docs/apis/json-rpc/#eth_getfilterchanges
Code: https://github.com/vechain/vechain-sdk-js/blob/1d488b389704b591f9d30377bd4b00af3683e826/packages/network/src/provider/utils/formatter/logs/formatter.ts#L26

victhorbi commented 2 months ago

We have collected some feedback from @ifavo , the lack of the feature requires him to have a workaround in place for The Graph indexing process. cc @fabiorigam

victhorbi commented 2 months ago

Protocol team will make the information available on the client.