vechain / vechain-sdk-js

The official JavaScript SDK for VeChain.
24 stars 9 forks source link

fix: missing explicit `ethers` import #1507

Closed freemanzMrojo closed 1 week ago

freemanzMrojo commented 1 week ago

Description

For the index.js bundle there was an issue because an explicit import of ethers 6 was missing.

Tested with the veworld-mobile repo and it works.

Closes #1506.

Type of change

How Has This Been Tested?

With the SDK test suite.

Besides that, I have modified the import at the veworld-mobile repo so package.json looks like this (I have both projects at the same level):

    "@vechain/sdk-core": "file:../vechain-sdk-js/packages/core",
    "@vechain/sdk-network": "file:../vechain-sdk-js/packages/network",

After this, just run:

  1. yarn install:all
  2. yarn test

All tests are passing for me.

Test Configuration:

Checklist:

github-actions[bot] commented 1 week ago

Test Coverage

Summary

Lines Statements Branches Functions
Coverage: 99%
98.99% (4343/4387) 97.53% (1387/1422) 99% (896/905)
Title Tests Skipped Failures Errors Time
core 827 0 :zzz: 0 :x: 0 :fire: 2m 21s :stopwatch:
network 719 0 :zzz: 0 :x: 0 :fire: 5m 7s :stopwatch:
errors 42 0 :zzz: 0 :x: 0 :fire: 17.019s :stopwatch:
logging 3 0 :zzz: 0 :x: 0 :fire: 18.394s :stopwatch:
hardhat-plugin 19 0 :zzz: 0 :x: 0 :fire: 59.553s :stopwatch:
aws-kms-adapter 23 0 :zzz: 0 :x: 0 :fire: 1m 30s :stopwatch:
ethers-adapter 5 0 :zzz: 0 :x: 0 :fire: 1m 12s :stopwatch:
rpc-proxy 37 0 :zzz: 0 :x: 0 :fire: 1m 3s :stopwatch:
leszek-vechain commented 1 week ago

is there any way we can add a test for it on our side ? before it goes to external clients like veworld ?

freemanzMrojo commented 1 week ago

is there any way we can add a test for it on our side ? before it goes to external clients like veworld ?

The closest I am aware of is what I did locally and described above.