vechain / vechain-sdk-js

The official JavaScript SDK for VeChain.
24 stars 9 forks source link

Rationalise Testing Accounts & Strategy #858

Closed nwbrettski closed 14 hours ago

nwbrettski commented 6 months ago

We need to migrate our testing accounts off thor solo accounts and use some specified and SDK team owned and controlled accounts.

Tasks:

Acceptance Criteria:

Links:

nwbrettski commented 6 months ago

Pulling this back as the QA team are coming up with an idea on how to make a standard library for use by all products.

lucanicoladebiasi commented 4 months ago

Testing the e2e-utils to create One Time Use (OTU) account in Thor.

lucanicoladebiasi commented 4 months ago

We tsted the e2e-utils with @leszek-vechain and agreed the following.

  1. A npm library will be published to let SDK to import the specialized client to connect with the e2e-utils service to create one-time-use accounts and get its coordinates for tests.
  2. The account-server: section of e2e-utils at docker-compose.yml must be imported in the docker-compose.yaml of vechain-sdk-js but to do this, the thor-solo image must be pulled by docker-hub and referenced in account-server:image tag of the docker compose YAML configuration file. This action will let the SDK to start thor-solo( and the e2e-utils* service and allow the SDK test code to connect with the ad-hoc account generation service.

Few bugs solved and suggestions discussed.

lucanicoladebiasi commented 4 months ago

From today (23/8/2024) stand-up, @leszek-vechain reports needed changes won't be available before the end of this week. Preparing the test code for e2e-utils meanwhile.

leszek-vechain commented 4 months ago

The account manager docker image is here:

https://github.com/vechain/e2e-utils/pkgs/container/e2e-account-manager

I think we should be able to include it in sdk docker-compose.yaml

npm client should be ready soon

leszek-vechain commented 4 months ago

The dependency for e2e utils is here:

https://github.com/vechain/e2e-utils/pkgs/npm/e2e-utils

so now we should be able to use it together

victhorbi commented 4 months ago

Lowering the priority in favor of the refactoring of the core part. Since it will probably bring breaking changes, let's make sure we do it before the official release.

lucanicoladebiasi commented 1 month ago

Resuming this ticket after core refactoring. I use https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API as REST library instead of axios.

leszek-vechain commented 1 month ago

yeah thats good idea to switch it to fetch, axios was selected as it was done during prototyping :D