vechain / vechain-sdk-js

The official JavaScript SDK for VeChain.

19 stars 6 forks source link

fix: make address optional/ index #892

Closed darrenvechain closed 1 month ago

darrenvechain commented 1 month ago

Description

Fix interfaces

Checklist:

[x] My code follows the coding standards of this project
[x] I have performed a self-review of my code
[x] I have commented on my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] New and existing integration tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have not added any vulnerable dependencies to my code

darrenvechain commented 1 month ago

@rodolfopietro97 I linked v5 ethers, here is v6:

https://docs.ethers.org/v6/api/providers/jsonrpc/#JsonRpcApiProvider-getSigner

github-actions[bot] commented 1 month ago

Test Coverage

Summary

Lines	Statements	Branches	Functions
	99.79% (3368/3375)	99.23% (775/781)	99.56% (692/695)

Title	Tests	Skipped	Failures	Errors	Time
core	478	0 :zzz:	0 :x:	0 :fire:	1m 10s :stopwatch:
network	647	0 :zzz:	0 :x:	0 :fire:	3m 49s :stopwatch:
errors	48	0 :zzz:	0 :x:	0 :fire:	11.263s :stopwatch: