vectara / create-ui

Generate a working React codebase for a range of generative and semantic search UIs
https://vectara.github.io/create-ui
Apache License 2.0
69 stars 12 forks source link

Is `scripts/dev.js` necessary? #6

Closed cjcenizal closed 10 months ago

cjcenizal commented 11 months ago

https://github.com/vectara/create-ui/pull/4 introduced this script, which enables local development by copying files from the appropriate app template into a temporary dev/ directory, installing dependencies, and running the app locally.

Ironically, this PR also refactors the app template folder structure, which makes this script moot because a maintainer can just cd into the app template directory, install dependencies, and run the app locally for the same effect.

However, this depends on having a .env file in the app template directory, which configures the app. @mrderyk How will your changes affect this process? Will it still be possible to just run an app locally from within its source directory? If so then maybe we can do away with scripts/dev.js.

cjcenizal commented 10 months ago

After discussion, we decided that we can remove dev.js and replace it with:

mrderyk commented 10 months ago

PR is here: https://github.com/vectara/create-ui/pull/15