vector-engineering / covidcg

A COVID-19 CoV Genetics (CG) browser to inform therapeutics development
https://covidcg.org
MIT License
26 stars 5 forks source link

Lineage Tree Legend and X-axis ticks #356

Closed atc3 closed 3 years ago

atc3 commented 3 years ago

image

Current lineage tree implementation doesn't have a legend

I can't add it to the main Vega spec since I can't switch between legends. If I want to show one of them, I'll have to show all of them, and this takes up too much vertical space. Also, it will scroll with the rest of the plot and be scrolled out of view when scrolling down the tree itself.

I tried making a separate Vega plot with just the legends, but had problems spacing everything out. I think this is the way to go, I just have to figure out a few glitches.

Another option is to make the legend in pure React, although there's no guarantee that the colors will match up exactly

The x-axis has the same problem, except it's much harder to make in React since I'll have to line up the React x-axis exactly with the Vega one. Not sure if this will ever be possible, without a rewrite of this plot from Vega to pure d3