search

vector-engineering / covidcg

A COVID-19 CoV Genetics (CG) browser to inform therapeutics development
https://covidcg.org
MIT License
26 stars 5 forks source link

Per-service installation: location of defs.json is hardcoded so flask server fails #381

Closed monkollek closed 3 years ago

monkollek commented 3 years ago

I would change this so it's not hardcoded and perhaps location be specific in the CONFIGFILE? https://github.com/vector-engineering/covidcg/blob/master/services/server/cg_server/constants.py#L13

I''m assuming it should point to this file on the repo? https://github.com/vector-engineering/covidcg/blob/master/src/constants/defs.json

atc3 commented 3 years ago

Yes, thanks for the feedback. The current path is relative to the container during a docker deployment, but maybe it would be better to define this path via. an environment variable that defaults to the relative path in the repository

atc3 commented 3 years ago

Closed by #384, please let me know if this fixed your problem